lkml.org 
[lkml]   [2021]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v13 7/7] kasan: don't run tests in async mode
    On Fri, Feb 12, 2021 at 6:22 PM Catalin Marinas <catalin.marinas@arm.com> wrote:
    >
    > On Thu, Feb 11, 2021 at 03:33:53PM +0000, Vincenzo Frascino wrote:
    > > From: Andrey Konovalov <andreyknvl@google.com>
    > >
    > > Asynchronous KASAN mode doesn't guarantee that a tag fault will be
    > > detected immediately and causes tests to fail. Forbid running them
    > > in asynchronous mode.
    > >
    > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
    > > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
    > > ---
    > > lib/test_kasan.c | 4 ++++
    > > 1 file changed, 4 insertions(+)
    > >
    > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c
    > > index f8c72d3aed64..77a60592d350 100644
    > > --- a/lib/test_kasan.c
    > > +++ b/lib/test_kasan.c
    > > @@ -51,6 +51,10 @@ static int kasan_test_init(struct kunit *test)
    > > kunit_err(test, "can't run KASAN tests with KASAN disabled");
    > > return -1;
    > > }
    > > + if (kasan_flag_async) {
    > > + kunit_err(test, "can't run KASAN tests in async mode");
    > > + return -1;
    > > + }
    >
    > I think we have time to fix this properly ;), so I'd rather not add this
    > patch at all.

    Yeah, this patch can be dropped.

    I have a prototype of async support for tests working. I'll apply it
    on top of the next version Vincenzo posts and share the patch.

    Vincenzo, when you post the next version, please make sure you rebase
    on top of the mm tree version that includes "kasan: export HW_TAGS
    symbols for KUnit tests" (linux-next/akpm doesn't yet have it).

    \
     
     \ /
      Last update: 2021-02-12 22:47    [W:2.818 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site