lkml.org 
[lkml]   [2021]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v5 net-next 03/10] net: bridge: don't print in br_switchdev_set_port_flag
    From
    Date


    On 2/12/2021 7:15 AM, Vladimir Oltean wrote:
    > From: Vladimir Oltean <vladimir.oltean@nxp.com>
    >
    > For the netlink interface, propagate errors through extack rather than
    > simply printing them to the console. For the sysfs interface, we still
    > print to the console, but at least that's one layer higher than in
    > switchdev, which also allows us to silently ignore the offloading of
    > flags if that is ever needed in the future.
    >
    > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

    I suppose the slight "loss" of information on which port failed the
    operation is okay since it was implied by either the path (sysfs) or the
    bridge command.
    --
    Florian

    \
     
     \ /
      Last update: 2021-02-12 19:10    [W:2.712 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site