Messages in this thread | | | Date | Fri, 12 Feb 2021 11:13:05 -0500 | From | Mike Snitzer <> | Subject | Re: [PATCH v5 4/6] dm: new ioctl DM_DEV_REMAP_CMD |
| |
On Tue, Feb 09 2021 at 9:30am -0500, Sergei Shtepa <sergei.shtepa@veeam.com> wrote:
> New ioctl DM_DEV_REMAP_CMD allow to remap bio requests > from regular block device to dm device.
I really dislike the (ab)use of "REMAP" for this. DM is and always has been about remapping IO. Would prefer DM_DEV_INTERPOSE_CMD
Similarly, all places documenting "remap" or variables with "remap" changed to "interpose".
Also, any chance you'd be open to putting all these interposer specific changes in dm-interposer.[ch] ? (the various internal structs for DM core _should_ be available via dm-core.h)
Mike
| |