Messages in this thread | | | Subject | Re: [PATCH -next] NTB: Drop kfree for memory allocated with devm_kzalloc | From | Kishon Vijay Abraham I <> | Date | Fri, 12 Feb 2021 18:18:31 +0530 |
| |
On 10/02/21 1:23 pm, Wei Yongjun wrote: > It's not necessary to free memory allocated with devm_kzalloc > and using kfree leads to a double free. > > Fixes: 363baf7d6051 ("NTB: Add support for EPF PCI-Express Non-Transparent Bridge") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/ntb/hw/epf/ntb_hw_epf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/ntb/hw/epf/ntb_hw_epf.c b/drivers/ntb/hw/epf/ntb_hw_epf.c > index 2cccb7dff5dd..b019755e4e21 100644 > --- a/drivers/ntb/hw/epf/ntb_hw_epf.c > +++ b/drivers/ntb/hw/epf/ntb_hw_epf.c > @@ -723,7 +723,6 @@ static void ntb_epf_pci_remove(struct pci_dev *pdev) > ntb_unregister_device(&ndev->ntb); > ntb_epf_cleanup_isr(ndev); > ntb_epf_deinit_pci(ndev); > - kfree(ndev); > }
Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> > > static const struct ntb_epf_data j721e_data = { >
| |