lkml.org 
[lkml]   [2021]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vfio/type1: Use follow_pte()
Hi Alex,

I love your patch! Yet something to improve:

[auto build test ERROR on vfio/next]
[also build test ERROR on v5.11-rc7 next-20210211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Alex-Williamson/vfio-type1-Use-follow_pte/20210213-030541
base: https://github.com/awilliam/linux-vfio.git next
config: i386-randconfig-a002-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/d1aea3bcf226e5225e706acb7df2f4c68ea8858a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alex-Williamson/vfio-type1-Use-follow_pte/20210213-030541
git checkout d1aea3bcf226e5225e706acb7df2f4c68ea8858a
# save the attached .config to linux build tree
make W=1 ARCH=i386

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

In file included from include/linux/mm.h:33,
from include/linux/scatterlist.h:8,
from include/linux/iommu.h:10,
from drivers/vfio/vfio_iommu_type1.c:27:
drivers/vfio/vfio_iommu_type1.c: In function 'follow_fault_pfn':
>> include/linux/pgtable.h:81:24: error: implicit declaration of function 'kunmap_atomic'; did you mean 'iommu_map_atomic'? [-Werror=implicit-function-declaration]
81 | #define pte_unmap(pte) kunmap_atomic((pte))
| ^~~~~~~~~~~~~
include/linux/mm.h:2231:2: note: in expansion of macro 'pte_unmap'
2231 | pte_unmap(pte); \
| ^~~~~~~~~
drivers/vfio/vfio_iommu_type1.c:494:2: note: in expansion of macro 'pte_unmap_unlock'
494 | pte_unmap_unlock(ptep, ptl);
| ^~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors


vim +81 include/linux/pgtable.h

974b9b2c68f3d3 Mike Rapoport 2020-06-08 76
974b9b2c68f3d3 Mike Rapoport 2020-06-08 77 #if defined(CONFIG_HIGHPTE)
974b9b2c68f3d3 Mike Rapoport 2020-06-08 78 #define pte_offset_map(dir, address) \
974b9b2c68f3d3 Mike Rapoport 2020-06-08 79 ((pte_t *)kmap_atomic(pmd_page(*(dir))) + \
974b9b2c68f3d3 Mike Rapoport 2020-06-08 80 pte_index((address)))
974b9b2c68f3d3 Mike Rapoport 2020-06-08 @81 #define pte_unmap(pte) kunmap_atomic((pte))
974b9b2c68f3d3 Mike Rapoport 2020-06-08 82 #else
974b9b2c68f3d3 Mike Rapoport 2020-06-08 83 #define pte_offset_map(dir, address) pte_offset_kernel((dir), (address))
974b9b2c68f3d3 Mike Rapoport 2020-06-08 84 #define pte_unmap(pte) ((void)(pte)) /* NOP */
974b9b2c68f3d3 Mike Rapoport 2020-06-08 85 #endif
974b9b2c68f3d3 Mike Rapoport 2020-06-08 86

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2021-02-12 23:49    [W:0.172 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site