lkml.org 
[lkml]   [2021]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 2/4] usb: typec: tps6598x: Add trace event for status register
Hi "Guido,

I love your patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v5.11-rc7 next-20210211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Guido-G-nther/usb-typec-tps6598x-Add-IRQ-flag-and-register-tracing/20210212-001108
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: microblaze-randconfig-r026-20210209 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/17785e43289bc7b92db7b401cd53a37c7a9faed2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Guido-G-nther/usb-typec-tps6598x-Add-IRQ-flag-and-register-tracing/20210212-001108
git checkout 17785e43289bc7b92db7b401cd53a37c7a9faed2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/usb/typec/./tps6598x_trace.h:137:1: note: in expansion of macro 'TRACE_EVENT'
137 | TRACE_EVENT(tps6598x_irq,
| ^~~~~~~~~~~
drivers/usb/typec/./tps6598x_trace.h:152:6: note: in expansion of macro 'TP_printk'
152 | TP_printk("event1=%s, event2=%s",
| ^~~~~~~~~
drivers/usb/typec/./tps6598x_trace.h:22:2: note: in expansion of macro '__print_flags'
22 | __print_flags(flags, "|", \
| ^~~~~~~~~~~~~
drivers/usb/typec/tps6598x.h:83:48: note: in expansion of macro 'BIT'
83 | #define TPS_REG_INT_USER_VID_ALT_MODE_ENTERED BIT(24+32)
| ^~~
drivers/usb/typec/./tps6598x_trace.h:65:5: note: in expansion of macro 'TPS_REG_INT_USER_VID_ALT_MODE_ENTERED'
65 | { TPS_REG_INT_USER_VID_ALT_MODE_ENTERED, "USER_VID_ALT_MODE_ENTERED" }, \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/typec/./tps6598x_trace.h:154:9: note: in expansion of macro 'show_irq_flags'
154 | show_irq_flags(__entry->event2))
| ^~~~~~~~~~~~~~
include/vdso/bits.h:7:26: warning: left shift count >= width of type [-Wshift-count-overflow]
7 | #define BIT(nr) (UL(1) << (nr))
| ^~
include/trace/trace_events.h:367:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
367 | trace_seq_printf(s, print); \
| ^~~~~
include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
80 | PARAMS(print)); \
| ^~~~~~
drivers/usb/typec/./tps6598x_trace.h:137:1: note: in expansion of macro 'TRACE_EVENT'
137 | TRACE_EVENT(tps6598x_irq,
| ^~~~~~~~~~~
drivers/usb/typec/./tps6598x_trace.h:152:6: note: in expansion of macro 'TP_printk'
152 | TP_printk("event1=%s, event2=%s",
| ^~~~~~~~~
drivers/usb/typec/./tps6598x_trace.h:22:2: note: in expansion of macro '__print_flags'
22 | __print_flags(flags, "|", \
| ^~~~~~~~~~~~~
drivers/usb/typec/tps6598x.h:82:45: note: in expansion of macro 'BIT'
82 | #define TPS_REG_INT_USER_VID_ALT_MODE_EXIT BIT(25+32)
| ^~~
drivers/usb/typec/./tps6598x_trace.h:66:5: note: in expansion of macro 'TPS_REG_INT_USER_VID_ALT_MODE_EXIT'
66 | { TPS_REG_INT_USER_VID_ALT_MODE_EXIT, "USER_VID_ALT_MODE_EXIT" }, \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/typec/./tps6598x_trace.h:154:9: note: in expansion of macro 'show_irq_flags'
154 | show_irq_flags(__entry->event2))
| ^~~~~~~~~~~~~~
include/vdso/bits.h:7:26: warning: left shift count >= width of type [-Wshift-count-overflow]
7 | #define BIT(nr) (UL(1) << (nr))
| ^~
include/trace/trace_events.h:367:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
367 | trace_seq_printf(s, print); \
| ^~~~~
include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
80 | PARAMS(print)); \
| ^~~~~~
drivers/usb/typec/./tps6598x_trace.h:137:1: note: in expansion of macro 'TRACE_EVENT'
137 | TRACE_EVENT(tps6598x_irq,
| ^~~~~~~~~~~
drivers/usb/typec/./tps6598x_trace.h:152:6: note: in expansion of macro 'TP_printk'
152 | TP_printk("event1=%s, event2=%s",
| ^~~~~~~~~
drivers/usb/typec/./tps6598x_trace.h:22:2: note: in expansion of macro '__print_flags'
22 | __print_flags(flags, "|", \
| ^~~~~~~~~~~~~
drivers/usb/typec/tps6598x.h:81:49: note: in expansion of macro 'BIT'
81 | #define TPS_REG_INT_USER_VID_ALT_MODE_ATTN_VDM BIT(26+32)
| ^~~
drivers/usb/typec/./tps6598x_trace.h:67:5: note: in expansion of macro 'TPS_REG_INT_USER_VID_ALT_MODE_ATTN_VDM'
67 | { TPS_REG_INT_USER_VID_ALT_MODE_ATTN_VDM, "USER_VID_ALT_MODE_ATTN_VDM" }, \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/typec/./tps6598x_trace.h:154:9: note: in expansion of macro 'show_irq_flags'
154 | show_irq_flags(__entry->event2))
| ^~~~~~~~~~~~~~
include/vdso/bits.h:7:26: warning: left shift count >= width of type [-Wshift-count-overflow]
7 | #define BIT(nr) (UL(1) << (nr))
| ^~
include/trace/trace_events.h:367:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
367 | trace_seq_printf(s, print); \
| ^~~~~
include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
80 | PARAMS(print)); \
| ^~~~~~
drivers/usb/typec/./tps6598x_trace.h:137:1: note: in expansion of macro 'TRACE_EVENT'
137 | TRACE_EVENT(tps6598x_irq,
| ^~~~~~~~~~~
drivers/usb/typec/./tps6598x_trace.h:152:6: note: in expansion of macro 'TP_printk'
152 | TP_printk("event1=%s, event2=%s",
| ^~~~~~~~~
drivers/usb/typec/./tps6598x_trace.h:22:2: note: in expansion of macro '__print_flags'
22 | __print_flags(flags, "|", \
| ^~~~~~~~~~~~~
drivers/usb/typec/tps6598x.h:80:50: note: in expansion of macro 'BIT'
80 | #define TPS_REG_INT_USER_VID_ALT_MODE_OTHER_VDM BIT(27+32)
| ^~~
drivers/usb/typec/./tps6598x_trace.h:68:5: note: in expansion of macro 'TPS_REG_INT_USER_VID_ALT_MODE_OTHER_VDM'
68 | { TPS_REG_INT_USER_VID_ALT_MODE_OTHER_VDM, "USER_VID_ALT_MODE_OTHER_VDM" })
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/typec/./tps6598x_trace.h:154:9: note: in expansion of macro 'show_irq_flags'
154 | show_irq_flags(__entry->event2))
| ^~~~~~~~~~~~~~
drivers/usb/typec/./tps6598x_trace.h: In function 'trace_raw_output_tps6598x_status':
>> drivers/usb/typec/tps6598x.h:28:35: error: implicit declaration of function 'FIELD_GET'; did you mean 'FOLL_GET'? [-Werror=implicit-function-declaration]
28 | #define TPS_STATUS_CONN_STATE(x) FIELD_GET(TPS_STATUS_CONN_STATE_MASK, (x))
| ^~~~~~~~~
include/trace/trace_events.h:367:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
367 | trace_seq_printf(s, print); \
| ^~~~~
include/trace/trace_events.h:80:9: note: in expansion of macro 'PARAMS'
80 | PARAMS(print)); \
| ^~~~~~
drivers/usb/typec/./tps6598x_trace.h:157:1: note: in expansion of macro 'TRACE_EVENT'
157 | TRACE_EVENT(tps6598x_status,
| ^~~~~~~~~~~
drivers/usb/typec/./tps6598x_trace.h:169:6: note: in expansion of macro 'TP_printk'
169 | TP_printk("conn: %s, pp_5v0: %s, pp_hv: %s, pp_ext: %s, pp_cable: %s, "
| ^~~~~~~~~
drivers/usb/typec/./tps6598x_trace.h:81:2: note: in expansion of macro '__print_symbolic'
81 | __print_symbolic(TPS_STATUS_CONN_STATE((status)), \
| ^~~~~~~~~~~~~~~~
drivers/usb/typec/./tps6598x_trace.h:81:19: note: in expansion of macro 'TPS_STATUS_CONN_STATE'
81 | __print_symbolic(TPS_STATUS_CONN_STATE((status)), \
| ^~~~~~~~~~~~~~~~~~~~~
drivers/usb/typec/./tps6598x_trace.h:171:9: note: in expansion of macro 'show_status_conn_state'
171 | show_status_conn_state(__entry->status),
| ^~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors


vim +28 drivers/usb/typec/tps6598x.h

26
27 #define TPS_STATUS_CONN_STATE_MASK GENMASK(3, 1)
> 28 #define TPS_STATUS_CONN_STATE(x) FIELD_GET(TPS_STATUS_CONN_STATE_MASK, (x))
29 #define TPS_STATUS_PP_5V0_SWITCH_MASK GENMASK(9, 8)
30 #define TPS_STATUS_PP_5V0_SWITCH(x) FIELD_GET(TPS_STATUS_PP_5V0_SWITCH_MASK, (x))
31 #define TPS_STATUS_PP_HV_SWITCH_MASK GENMASK(11, 10)
32 #define TPS_STATUS_PP_HV_SWITCH(x) FIELD_GET(TPS_STATUS_PP_HV_SWITCH_MASK, (x))
33 #define TPS_STATUS_PP_EXT_SWITCH_MASK GENMASK(13, 12)
34 #define TPS_STATUS_PP_EXT_SWITCH(x) FIELD_GET(TPS_STATUS_PP_EXT_SWITCH_MASK, (x))
35 #define TPS_STATUS_PP_CABLE_SWITCH_MASK GENMASK(15, 14)
36 #define TPS_STATUS_PP_CABLE_SWITCH(x) FIELD_GET(TPS_STATUS_PP_CABLE_SWITCH_MASK, (x))
37 #define TPS_STATUS_POWER_SOURCE_MASK GENMASK(19, 18)
38 #define TPS_STATUS_POWER_SOURCE(x) FIELD_GET(TPS_STATUS_POWER_SOURCE_MASK, (x))
39 #define TPS_STATUS_VBUS_STATUS_MASK GENMASK(21, 20)
40 #define TPS_STATUS_VBUS_STATUS(x) FIELD_GET(TPS_STATUS_VBUS_STATUS_MASK, (x))
41 #define TPS_STATUS_USB_HOST_PRESENT_MASK GENMASK(23, 22)
42 #define TPS_STATUS_USB_HOST_PRESENT(x) FIELD_GET(TPS_STATUS_USB_HOST_PRESENT_MASK, (x))
43 #define TPS_STATUS_LEGACY_MASK GENMASK(25, 24)
44 #define TPS_STATUS_LEGACY(x) FIELD_GET(TPS_STATUS_LEGACY_MASK, (x))
45

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2021-02-11 19:23    [W:0.362 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site