lkml.org 
[lkml]   [2021]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] pinctrl: imx: imx8mm: fix pad offset of SD1_DATA0 pin
From
Date
On 2/11/21 11:17 AM, Frieder Schrempf wrote:
> On 11.02.21 10:54, Claudius Heine wrote:
>> There is a 0 missing in the pad register offset. This patch adds it.
>>
>> Signed-off-by: Claudius Heine <ch@denx.de>
>
> I think this should rather be prefixed by "arm64: dts: imx8mm:" as this
> is no change in the pinctrl driver, but only in the devicetree.
>
> And I guess this deserves a "Fixes" and "Cc: stable" tag, so:
>
> Fixes: c1c9d41319c3 ("dt-bindings: imx: Add pinctrl binding doc for
> imx8mm")
> Cc: stable@vger.kernel.org
> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>

Indeed.

But since this isn't the first such fix, I wonder whether it wouldn't be
a good idea to regenerate those pinctrl tables and see whether there are
any other such issues in them. I wonder, is there some sort of register
and bit list in machine-parseable form for the MX8M ?

\
 
 \ /
  Last update: 2021-02-11 12:49    [W:0.554 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site