Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 11 Feb 2021 12:02:58 +0200 | Subject | Re: [PATCH] platform/x86: intel_scu_ipc: Increase virtual timeout from 3 to 5 seconds |
| |
On Wed, Feb 10, 2021 at 9:20 PM Casey Bowman <casey.g.bowman@intel.com> wrote: > > Increasing the virtual timeout time to account for scenarios > that may require more time, like DisplayPort Multi-Stream Transport > (DP MST), where the disconnect time can be extended longer than > usual. > > The recommended timeout range is 5-10 seconds, of which > we will take the lower bound.
Since the driver is used across several platforms, can we somehow be more flexible with it on a per platform basis or so (per command?)? In general I'm not against the patch and I usually don't see the long timeouts on other platforms, so if Hans thinks it's okay to take, Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Casey Bowman <casey.g.bowman@intel.com> > Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> > --- > drivers/platform/x86/intel_scu_ipc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel_scu_ipc.c b/drivers/platform/x86/intel_scu_ipc.c > index d9cf7f7602b0..9171a46a9e3f 100644 > --- a/drivers/platform/x86/intel_scu_ipc.c > +++ b/drivers/platform/x86/intel_scu_ipc.c > @@ -75,7 +75,7 @@ struct intel_scu_ipc_dev { > #define IPC_READ_BUFFER 0x90 > > /* Timeout in jiffies */ > -#define IPC_TIMEOUT (3 * HZ) > +#define IPC_TIMEOUT (5 * HZ) > > static struct intel_scu_ipc_dev *ipcdev; /* Only one for now */ > static DEFINE_MUTEX(ipclock); /* lock used to prevent multiple call to SCU */ > -- > 2.17.1 >
-- With Best Regards, Andy Shevchenko
| |