Messages in this thread |  | | Date | Fri, 12 Feb 2021 00:28:42 +0100 | From | Pali Rohár <> | Subject | Re: [PATCH v2 06/12] arm64: dts: marvell: armada-3270-espressobin: add comphy references |
| |
On Wednesday 10 February 2021 16:09:43 kostap@marvell.com wrote: > From: Grzegorz Jaszczyk <jaz@semihalf.com> > > Add "phys" entries pointing to COMPHYs to PCIe and USB3 nodes > > Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com> > Signed-off-by: Konstantin Porotchkin <kostap@marvell.com>
Hello! This patch is not needed and now does nothing.
> --- > arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi > index daffe136c523..bbd955909813 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi > @@ -59,6 +59,8 @@ > /* J9 */ > &pcie0 { > status = "okay"; > + /* Generic PHY, providing serdes lanes */ > + phys = <&comphy1 0>;
In mainline kernel is PCIe PHY already provided in armada-37xx.dtsi: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-37xx.dtsi#n497
> pinctrl-names = "default"; > pinctrl-0 = <&pcie_reset_pins &pcie_clkreq_pins>; > reset-gpios = <&gpiosb 3 GPIO_ACTIVE_LOW>; > @@ -139,6 +141,9 @@ > /* J7 */ > &usb3 { > status = "okay"; > + /* Generic PHY, providing serdes lanes */ > + phys = <&comphy0 0>; > + phy-names = "usb";
In mainline kernel is USB 3.0 PHY already provided in armada-37xx.dtsi: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-37xx.dtsi#n359
> }; > > /* J8 */ > -- > 2.17.1 >
So final binary espressobin DTB files are same with and without this patch.
|  |