Messages in this thread | | | Date | Thu, 11 Feb 2021 14:13:07 -0800 (PST) | Subject | Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver | From | David Miller <> |
| |
From: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> Date: Thu, 11 Feb 2021 01:29:52 +0900
> +static int visconti_eth_init_hw(struct platform_device *pdev, struct plat_stmmacenet_data *plat_dat) > +{ > + struct visconti_eth *dwmac; > + unsigned int reg_val, clk_sel_val;
Please use reverse christmas tree ordering for local variable declarations.
> +static int visconti_eth_clock_probe(struct platform_device *pdev, > + struct plat_stmmacenet_data *plat_dat) > +{ > + int err; > + struct visconti_eth *dwmac;
Likewise.
> +static int visconti_eth_clock_remove(struct platform_device *pdev) > +{ > + struct net_device *ndev = platform_get_drvdata(pdev); > + struct stmmac_priv *priv = netdev_priv(ndev); > + struct visconti_eth *dwmac = get_stmmac_bsp_priv(&pdev->dev); Likewise.
Thanks.
| |