Messages in this thread |  | | Date | Thu, 11 Feb 2021 09:12:14 +0100 | From | Oscar Salvador <> | Subject | Re: [PATCH v2] mm/hugetlb: Remove unnecessary VM_BUG_ON_PAGE on putback_active_hugepage() |
| |
On Tue, Feb 09, 2021 at 02:11:51AM -0500, Miaohe Lin wrote: > All callers know they are operating on a hugetlb head page. So this > VM_BUG_ON_PAGE can not catch anything useful. > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
> --- > mm/hugetlb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 06719fdf9fd6..cfa06fd1b8d7 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -5577,7 +5577,6 @@ bool isolate_huge_page(struct page *page, struct list_head *list) > > void putback_active_hugepage(struct page *page) > { > - VM_BUG_ON_PAGE(!PageHead(page), page); > spin_lock(&hugetlb_lock); > SetHPageMigratable(page); > list_move_tail(&page->lru, &(page_hstate(page))->hugepage_activelist); > -- > 2.19.1 > >
-- Oscar Salvador SUSE L3
|  |