lkml.org 
[lkml]   [2021]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [v7 PATCH 01/12] mm: vmscan: use nid from shrink_control for tracepoint
    On Tue, Feb 9, 2021 at 11:14 AM Shakeel Butt <shakeelb@google.com> wrote:
    >
    > On Tue, Feb 9, 2021 at 9:47 AM Yang Shi <shy828301@gmail.com> wrote:
    > >
    > > The tracepoint's nid should show what node the shrink happens on, the start tracepoint
    > > uses nid from shrinkctl, but the nid might be set to 0 before end tracepoint if the
    > > shrinker is not NUMA aware, so the traceing
    >
    > tracing

    Fixed. Thanks.

    >
    > > log may show the shrink happens on one
    > > node but end up on the other node. It seems confusing. And the following patch
    > > will remove using nid directly in do_shrink_slab(), this patch also helps cleanup
    > > the code.
    > >
    > > Acked-by: Vlastimil Babka <vbabka@suse.cz>
    > > Acked-by: Kirill Tkhai <ktkhai@virtuozzo.com>
    > > Signed-off-by: Yang Shi <shy828301@gmail.com>
    >
    > Reviewed-by: Shakeel Butt <shakeelb@google.com>

    \
     
     \ /
      Last update: 2021-02-10 18:01    [W:5.844 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site