lkml.org 
[lkml]   [2021]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/5] ARM: dts: rockchip: assign a fixed index to mmc devices on rv1108 boards
On Wed, Feb 10, 2021 at 11:49 AM Heiko Stübner <heiko@sntech.de> wrote:
> Am Mittwoch, 10. Februar 2021, 11:34:41 CET schrieb Arnd Bergmann:
> > On Wed, Feb 10, 2021 at 12:50 AM Heiko Stübner <heiko@sntech.de> wrote:
> > > Am Dienstag, 9. Februar 2021, 23:25:40 CET schrieb Arnd Bergmann:
> > Each board should have its own aliases node that describes
> > exactly which of the devices are wired up on that board, and
> > in which order. If there are connectors on the board that
> > are labeled in some form, then the aliases are meant to
> > match what is written on the board or in its documentation.
>
> Then we're at least in the clear for i2c, serial and the rest ... as these
> are numbered in the soc documentation, and all boards I've seen so
> far use these number also to identify these in schematics.

Ok, that is helpful. It would still be good to ensure that only aliases
exist for nodes that are actually enabled.

> So an i2c2 is always i2c2 even if i2c1 is not populated.
>
> And of course doing
> i2c0 = &i2c2
> would definitly confuse people to no end.

I think that's just an unfortunate choice of the labels here,
it's sometimes easier to just refer to the node by the full
path instead of the label.

Arnd

\
 
 \ /
  Last update: 2021-02-10 14:56    [W:0.065 / U:0.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site