[lkml]   [2021]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mm: page-writeback: simplify memcg handling in test_clear_page_writeback()
On Tue, Feb 9, 2021 at 1:45 PM Johannes Weiner <> wrote:
> Page writeback doesn't hold a page reference, which allows truncate to
> free a page the second PageWriteback is cleared. This used to require
> special attention in test_clear_page_writeback(), where we had to be
> careful not to rely on the unstable page->memcg binding and look up
> all the necessary information before clearing the writeback flag.
> Since commit 073861ed77b6 ("mm: fix VM_BUG_ON(PageTail) and
> BUG_ON(PageWriteback)") test_clear_page_writeback() is called with an
> explicit reference on the page, and this dance is no longer needed.
> Use unlock_page_memcg() and dec_lruvec_page_stat() directly.
> Signed-off-by: Johannes Weiner <>

Reviewed-by: Shakeel Butt <>

 \ /
  Last update: 2021-02-10 14:48    [W:0.108 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site