Messages in this thread Patch in this message | | | Date | Wed, 10 Feb 2021 13:57:07 +0300 | From | Dan Carpenter <> | Subject | [PATCH] module: potential uninitialized return in module_kallsyms_on_each_symbol() |
| |
Smatch complains that:
kernel/module.c:4472 module_kallsyms_on_each_symbol() error: uninitialized symbol 'ret'.
This warning looks like it could be correct if the &modules list is empty.
Fixes: 013c1667cf78 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- kernel/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/module.c b/kernel/module.c index 95186c9d81ea..9bd3c821d029 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -4447,7 +4447,7 @@ int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *, { struct module *mod; unsigned int i; - int ret; + int ret = 0; mutex_lock(&module_mutex); list_for_each_entry(mod, &modules, list) { -- 2.30.0
| |