lkml.org 
[lkml]   [2021]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 net-next 09/11] net: mscc: ocelot: use separate flooding PGID for broadcast
    Date
    From: Vladimir Oltean <vladimir.oltean@nxp.com>

    In preparation of offloading the bridge port flags which have
    independent settings for unknown multicast and for broadcast, we should
    also start reserving one destination Port Group ID for the flooding of
    broadcast packets, to allow configuring it individually.

    Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
    ---
    Changes in v3:
    None.

    Changes in v2:
    None.

    drivers/net/ethernet/mscc/ocelot.c | 13 ++++++++-----
    include/soc/mscc/ocelot.h | 15 ++++++++-------
    2 files changed, 16 insertions(+), 12 deletions(-)

    diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
    index f8b85ab8be5d..8c1052346b58 100644
    --- a/drivers/net/ethernet/mscc/ocelot.c
    +++ b/drivers/net/ethernet/mscc/ocelot.c
    @@ -1662,7 +1662,7 @@ int ocelot_init(struct ocelot *ocelot)
    /* Setup flooding PGIDs */
    for (i = 0; i < ocelot->num_flooding_pgids; i++)
    ocelot_write_rix(ocelot, ANA_FLOODING_FLD_MULTICAST(PGID_MC) |
    - ANA_FLOODING_FLD_BROADCAST(PGID_MC) |
    + ANA_FLOODING_FLD_BROADCAST(PGID_BC) |
    ANA_FLOODING_FLD_UNICAST(PGID_UC),
    ANA_FLOODING, i);
    ocelot_write(ocelot, ANA_FLOODING_IPMC_FLD_MC6_DATA(PGID_MCIPV6) |
    @@ -1683,15 +1683,18 @@ int ocelot_init(struct ocelot *ocelot)
    ocelot_write_rix(ocelot, 0, ANA_PGID_PGID, PGID_SRC + port);
    }

    - /* Allow broadcast MAC frames. */
    for_each_nonreserved_multicast_dest_pgid(ocelot, i) {
    u32 val = ANA_PGID_PGID_PGID(GENMASK(ocelot->num_phys_ports - 1, 0));

    ocelot_write_rix(ocelot, val, ANA_PGID_PGID, i);
    }
    - ocelot_write_rix(ocelot,
    - ANA_PGID_PGID_PGID(GENMASK(ocelot->num_phys_ports, 0)),
    - ANA_PGID_PGID, PGID_MC);
    + /* Allow broadcast and unknown L2 multicast to the CPU. */
    + ocelot_rmw_rix(ocelot, ANA_PGID_PGID_PGID(BIT(ocelot->num_phys_ports)),
    + ANA_PGID_PGID_PGID(BIT(ocelot->num_phys_ports)),
    + ANA_PGID_PGID, PGID_MC);
    + ocelot_rmw_rix(ocelot, ANA_PGID_PGID_PGID(BIT(ocelot->num_phys_ports)),
    + ANA_PGID_PGID_PGID(BIT(ocelot->num_phys_ports)),
    + ANA_PGID_PGID, PGID_BC);
    ocelot_write_rix(ocelot, 0, ANA_PGID_PGID, PGID_MCIPV4);
    ocelot_write_rix(ocelot, 0, ANA_PGID_PGID, PGID_MCIPV6);

    diff --git a/include/soc/mscc/ocelot.h b/include/soc/mscc/ocelot.h
    index d0d48e9620fb..7ee85527cb5f 100644
    --- a/include/soc/mscc/ocelot.h
    +++ b/include/soc/mscc/ocelot.h
    @@ -54,16 +54,17 @@
    * PGID_CPU: used for whitelisting certain MAC addresses, such as the addresses
    * of the switch port net devices, towards the CPU port module.
    * PGID_UC: the flooding destinations for unknown unicast traffic.
    - * PGID_MC: the flooding destinations for broadcast and non-IP multicast
    - * traffic.
    + * PGID_MC: the flooding destinations for non-IP multicast traffic.
    * PGID_MCIPV4: the flooding destinations for IPv4 multicast traffic.
    * PGID_MCIPV6: the flooding destinations for IPv6 multicast traffic.
    + * PGID_BC: the flooding destinations for broadcast traffic.
    */
    -#define PGID_CPU 59
    -#define PGID_UC 60
    -#define PGID_MC 61
    -#define PGID_MCIPV4 62
    -#define PGID_MCIPV6 63
    +#define PGID_CPU 58
    +#define PGID_UC 59
    +#define PGID_MC 60
    +#define PGID_MCIPV4 61
    +#define PGID_MCIPV6 62
    +#define PGID_BC 63

    #define for_each_unicast_dest_pgid(ocelot, pgid) \
    for ((pgid) = 0; \
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-02-10 10:29    [W:3.715 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site