Messages in this thread Patch in this message | | | Date | Wed, 10 Feb 2021 23:03:03 +0200 | From | Sakari Ailus <> | Subject | Re: [PATCH][next] media: i2c: imx334: Fix a read of the uninitialized variable ret |
| |
Hi Colin,
On Wed, Feb 10, 2021 at 07:07:52PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Currently there is a dev_err error message that is printing the > error status in variable ret (that has not been set) instead of > the correct error status from imx334->reset_gpio. Fix this. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: 9746b11715c3 ("media: i2c: Add imx334 camera sensor driver") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/media/i2c/imx334.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c > index 07e31bc2ef18..f8b1caf26c9b 100644 > --- a/drivers/media/i2c/imx334.c > +++ b/drivers/media/i2c/imx334.c > @@ -790,7 +790,8 @@ static int imx334_parse_hw_config(struct imx334 *imx334) > imx334->reset_gpio = devm_gpiod_get_optional(imx334->dev, "reset", > GPIOD_OUT_LOW); > if (IS_ERR(imx334->reset_gpio)) { > - dev_err(imx334->dev, "failed to get reset gpio %d", ret); > + dev_err(imx334->dev, "failed to get reset gpio %ld", > + IS_ERR_VALUE(imx334->reset_gpio)); > return PTR_ERR(imx334->reset_gpio); > }
Thanks for the patch. This has been already addressed by another patch here, and has just been applied to linux-media master.
commit c702e2f70275dbc5373aef50c450cf9c5730636c Author: Hans Verkuil <hverkuil@xs4all.nl> Date: Mon Feb 8 12:32:29 2021 +0100
media: imx334: 'ret' is uninitialized, should have been PTR_ERR() Fix this compiler warning: drivers/media/i2c/imx334.c: In function 'imx334_parse_hw_config': include/linux/dev_printk.h:112:2: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] 112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~ drivers/media/i2c/imx334.c:783:6: note: 'ret' was declared here 783 | int ret; | ^~~ Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
-- Kind regards,
Sakari Ailus
| |