Messages in this thread Patch in this message | | | Date | Thu, 11 Feb 2021 04:09:16 +0800 | From | kernel test robot <> | Subject | [PATCH] xfs: fix boolreturn.cocci warnings |
| |
From: kernel test robot <lkp@intel.com>
fs/xfs/xfs_log.c:1062:9-10: WARNING: return of 0/1 in function 'xfs_log_need_covered' with return type bool
Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 37444fc4cc39 ("xfs: lift writable fs check up into log worker task") CC: Brian Foster <bfoster@redhat.com> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> ---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git xfs-5.12-merge head: 560ab6c0d12ebccabb83638abe23a7875b946f9a commit: 37444fc4cc398266fe0f71a9c0925620d44fb76a [25/36] xfs: lift writable fs check up into log worker task
xfs_log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/xfs/xfs_log.c +++ b/fs/xfs/xfs_log.c @@ -1059,7 +1059,7 @@ xfs_log_need_covered( bool needed = false; if (!xlog_cil_empty(log)) - return 0; + return false; spin_lock(&log->l_icloglock); switch (log->l_covered_state) {
| |