lkml.org 
[lkml]   [2021]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 20/20] ata: pata_pdc2027x: Fix some incorrect function names and parameter docs
    Date
    Fixes the following W=1 kernel build warning(s):

    drivers/ata/pata_pdc2027x.c:209: warning: expecting prototype for pdc2027x_pata_cable_detect(). Prototype was for pdc2027x_cable_detect() instead
    drivers/ata/pata_pdc2027x.c:262: warning: expecting prototype for pdc2720x_mode_filter(). Prototype was for pdc2027x_mode_filter() instead
    drivers/ata/pata_pdc2027x.c:513: warning: Function parameter or member 'board_idx' not described in 'pdc_adjust_pll'
    drivers/ata/pata_pdc2027x.c:513: warning: expecting prototype for adjust_pll(). Prototype was for pdc_adjust_pll() instead
    drivers/ata/pata_pdc2027x.c:599: warning: expecting prototype for detect_pll_input_clock(). Prototype was for pdc_detect_pll_input_clock() instead

    Cc: Jens Axboe <axboe@kernel.dk>
    Cc: Albert Lee <albertcc@tw.ibm.com>
    Cc: Andre Hedrick <andre@linux-ide.org>
    Cc: Frank Tiernan <frankt@promise.com>
    Cc: linux-ide@vger.kernel.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/ata/pata_pdc2027x.c | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c
    index de834fbb6dfe6..effc1a09444de 100644
    --- a/drivers/ata/pata_pdc2027x.c
    +++ b/drivers/ata/pata_pdc2027x.c
    @@ -196,7 +196,7 @@ static inline void __iomem *dev_mmio(struct ata_port *ap, struct ata_device *ade
    }

    /**
    - * pdc2027x_pata_cable_detect - Probe host controller cable detect info
    + * pdc2027x_cable_detect - Probe host controller cable detect info
    * @ap: Port for which cable detect info is desired
    *
    * Read 80c cable indicator from Promise extended register.
    @@ -251,7 +251,7 @@ static int pdc2027x_prereset(struct ata_link *link, unsigned long deadline)
    }

    /**
    - * pdc2720x_mode_filter - mode selection filter
    + * pdc2027x_mode_filter - mode selection filter
    * @adev: ATA device
    * @mask: list of modes proposed
    *
    @@ -503,11 +503,11 @@ static long pdc_read_counter(struct ata_host *host)
    }

    /**
    - * adjust_pll - Adjust the PLL input clock in Hz.
    + * pdc_adjust_pll - Adjust the PLL input clock in Hz.
    *
    - * @pdc_controller: controller specific information
    * @host: target ATA host
    * @pll_clock: The input of PLL in HZ
    + * @board_idx: board identifier
    */
    static void pdc_adjust_pll(struct ata_host *host, long pll_clock, unsigned int board_idx)
    {
    @@ -590,7 +590,7 @@ static void pdc_adjust_pll(struct ata_host *host, long pll_clock, unsigned int b
    }

    /**
    - * detect_pll_input_clock - Detect the PLL input clock in Hz.
    + * pdc_detect_pll_input_clock - Detect the PLL input clock in Hz.
    * @host: target ATA host
    * Ex. 16949000 on 33MHz PCI bus for pdc20275.
    * Half of the PCI clock.
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-02-01 15:46    [W:2.806 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site