Messages in this thread | | | From | Desmond Yan <> | Date | Mon, 1 Feb 2021 10:32:19 -0800 | Subject | Re: [PATCH] misc: bcm-vk: unlock on error in bcm_to_h_msg_dequeue() |
| |
Acked-by: Desmond Yan <desmond.yan@broadcom.com>
On Mon, Feb 1, 2021 at 4:24 AM Dan Carpenter <dan.carpenter@oracle.com> wrote: > > Unlock before returning on this error path. > > Fixes: 111d746bb476 ("misc: bcm-vk: add VK messaging support") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/misc/bcm-vk/bcm_vk_msg.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/bcm-vk/bcm_vk_msg.c b/drivers/misc/bcm-vk/bcm_vk_msg.c > index eec90494777d..fc972e43258a 100644 > --- a/drivers/misc/bcm-vk/bcm_vk_msg.c > +++ b/drivers/misc/bcm-vk/bcm_vk_msg.c > @@ -849,7 +849,8 @@ s32 bcm_to_h_msg_dequeue(struct bcm_vk *vk) > * that is fatal. > */ > dev_crit(dev, "Kernel mem allocation failure.\n"); > - return -ENOMEM; > + total = -ENOMEM; > + goto idx_err; > } > > /* flush rd pointer after a message is dequeued */ > -- > 2.29.2 > [unhandled content-type:application/pkcs7-signature] | |