Messages in this thread | | | From | Jesper Dangaard Brouer <> | Date | Thu, 9 Dec 2021 09:27:37 +0100 | Subject | Re: [PATCH v4 net-next 2/9] i40e: respect metadata on XSK Rx to skb |
| |
On 08/12/2021 15.06, Alexander Lobakin wrote: > For now, if the XDP prog returns XDP_PASS on XSK, the metadata will > be lost as it doesn't get copied to the skb.
I have an urge to add a newline here, when reading this, as IMHO it is a paragraph with the problem statement.
> Copy it along with the frame headers. Account its size on skb > allocation, and when copying just treat it as a part of the frame > and do a pull after to "move" it to the "reserved" zone.
Also newline here, as next paragraph are some extra details, you felt a need to explain to the reader.
> net_prefetch() xdp->data_meta and align the copy size to speed-up > memcpy() a little and better match i40e_costruct_skb(). ^^^^^^xx^^^^^^^^^
You have a general misspelling of this function name in all of your commit messages.
--Jesper
| |