lkml.org 
[lkml]   [2021]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved
    On Thu, Dec 09, 2021 at 08:24:59PM +0300, Sergey Shtylyov wrote:
    > On 12/9/21 5:59 PM, Andy Shevchenko wrote:
    >
    > > platform_get_irq() will print a message when it fails.
    > > No need to repeat this.
    > >
    > > While at it, drop redundant check for 0 as platform_get_irq() spills
    > > out a big WARN() in such case.
    >
    > And? IRQ0 is still returned! :-(

    It should not be returned in the first place.

    ...

    > > - if (!irq)
    > > - return -EINVAL;
    >
    > This is prermature -- let's wait till my patch that stops returning IRQ0 from
    > platform_get_irq() and friends gets merged....

    What patch?

    Does it fix platform_get_irq_optional()?

    --
    With Best Regards,
    Andy Shevchenko


    \
     
     \ /
      Last update: 2021-12-09 18:44    [W:2.411 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site