Messages in this thread Patch in this message | | | Date | Tue, 7 Dec 2021 18:45:46 -0800 | Subject | [PATCH 01/22] libperf: Add comments to perf_cpu_map. | From | Ian Rogers <> |
| |
A particular observed problem is confusing the index with the CPU value, documentation should hopefully reduce this type of problem.
Signed-off-by: Ian Rogers <irogers@google.com> --- tools/lib/perf/include/internal/cpumap.h | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/tools/lib/perf/include/internal/cpumap.h b/tools/lib/perf/include/internal/cpumap.h index 840d4032587b..1c1726f4a04e 100644 --- a/tools/lib/perf/include/internal/cpumap.h +++ b/tools/lib/perf/include/internal/cpumap.h @@ -4,9 +4,16 @@ #include <linux/refcount.h> +/** + * A sized, reference counted, sorted array of integers representing CPU + * numbers. This is commonly used to capture which CPUs a PMU is associated + * with. + */ struct perf_cpu_map { refcount_t refcnt; + /** Length of the map array. */ int nr; + /** The CPU values. */ int map[]; }; -- 2.34.1.400.ga245620fadb-goog
| |