Messages in this thread | | | Date | Thu, 30 Dec 2021 21:10:42 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH v2] Input: spaceball - fix parsing of movement data packets |
| |
On Tue, Dec 21, 2021 at 02:16:31AM -0800, Leo L. Schwab wrote: > The spaceball.c module was not properly parsing the movement reports > coming from the device. The code read axis data as signed 16-bit > little-endian values starting at offset 2. > > In fact, axis data in Spaceball movement reports are signed 16-bit > big-endian values starting at offset 3. This was determined first by > visually inspecting the data packets, and later verified by consulting: > http://spacemice.org/pdf/SpaceBall_2003-3003_Protocol.pdf > > If this ever worked properly, it was in the time before Git... > > Signed-off-by: Leo L. Schwab <ewhac@ewhac.org>
Applied, thank you.
-- Dmitry
| |