Messages in this thread | | | Date | Tue, 28 Dec 2021 08:25:15 -0600 | Subject | Re: [greybus-dev] [PATCH] staging: greybus: auto_manager: use default_groups in kobj_type | From | Alex Elder <> |
| |
On 12/28/21 7:55 AM, Greg Kroah-Hartman wrote: > There are currently 2 ways to create a set of sysfs files for a > kobj_type, through the default_attrs field, and the default_groups > field. Move the greybus audio code to use default_groups field which > has been the preferred way since aa30f47cf666 ("kobject: Add support for > default attribute groups to kobj_type") so that we can soon get rid of > the obsolete default_attrs field. > > Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com> > Cc: Mark Greer <mgreer@animalcreek.com> > Cc: Johan Hovold <johan@kernel.org> > Cc: Alex Elder <elder@kernel.org> > Cc: greybus-dev@lists.linaro.org > Cc: linux-staging@lists.linux.dev > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nice and simple to convert this (as it should be). Looks good to me.
Reviewed-by: Alex Elder <elder@linaro.org>
> --- > drivers/staging/greybus/audio_manager_module.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c > index 525cf8f8394f..0a0f0a394c84 100644 > --- a/drivers/staging/greybus/audio_manager_module.c > +++ b/drivers/staging/greybus/audio_manager_module.c > @@ -142,11 +142,12 @@ static struct attribute *gb_audio_module_default_attrs[] = { > &gb_audio_module_op_devices_attribute.attr, > NULL, /* need to NULL terminate the list of attributes */ > }; > +ATTRIBUTE_GROUPS(gb_audio_module_default); > > static struct kobj_type gb_audio_module_type = { > .sysfs_ops = &gb_audio_module_sysfs_ops, > .release = gb_audio_module_release, > - .default_attrs = gb_audio_module_default_attrs, > + .default_groups = gb_audio_module_default_groups, > }; > > static void send_add_uevent(struct gb_audio_manager_module *module) >
| |