Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 22 Dec 2021 13:27:38 +0100 | Subject | Re: [PATCH 1/4] RDMA/irdma: Use auxiliary_device driver data helpers | From | Cezary Rojewski <> |
| |
On 2021-12-22 12:58 AM, David E. Box wrote: > Use auxiliary_get_drvdata and auxiliary_set_drvdata helpers. > > Signed-off-by: David E. Box <david.e.box@linux.intel.com> > --- > drivers/infiniband/hw/irdma/main.c | 4 ++-- > drivers/infiniband/hw/mlx5/main.c | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/infiniband/hw/irdma/main.c b/drivers/infiniband/hw/irdma/main.c > index 51a41359e0b4..9ccf4d683f8a 100644 > --- a/drivers/infiniband/hw/irdma/main.c > +++ b/drivers/infiniband/hw/irdma/main.c
While two occurrences of aux_dev->dev have been addressed here for irdma/main.c, there is one more that probably could get updated too:
static void irdma_iidc_event_handler(struct ice_pf *pf, struct iidrc_event *event) { struct irdma_device *iwdev = dev_get_drvdata(&pf->adev->dev); (...) }
Note: the declaration of struct ice_pf reads:
struct ice_pf { (...) struct auxiliary_device *adev; (...) };
leads into suggestion: struct irdma_device *iwdev = auxiliary_get_drvdata(pf->adev);
Of course, even if I'm right about this, such change could be applied with a separate patch and does not block the current review.
Regards, Czarek
| ![\](/images/icornerr.gif) |