Messages in this thread | | | Subject | Re: [PATCH v3 12/13] ARM: dts: imx: add i.MXRT1050-EVK support | From | Giulio Benetti <> | Date | Fri, 3 Dec 2021 01:20:51 +0100 |
| |
Hi Rob, Jesse,
On 28/11/21 17:43, Rob Herring wrote:
[SNIP]
>> diff --git a/arch/arm/boot/dts/imxrt1050.dtsi b/arch/arm/boot/dts/imxrt1050.dtsi >> new file mode 100644 >> index 000000000000..35943a6896fa >> --- /dev/null >> +++ b/arch/arm/boot/dts/imxrt1050.dtsi >> @@ -0,0 +1,165 @@ >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> +/* >> + * Copyright (C) 2019 >> + * Author(s): Giulio Benetti <giulio.benetti@benettiengineering.com> >> + */ >> + >> +#include "armv7-m.dtsi" >> +#include <dt-bindings/interrupt-controller/arm-gic.h> >> +#include <dt-bindings/clock/imxrt1050-clock.h> >> +#include <dt-bindings/gpio/gpio.h> >> + >> +/ { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + clocks { >> + osc: osc { >> + compatible = "fsl,imx-osc", "fixed-clock"; > > fsl,imx-osc is not documented. IMO, just drop it.
Regarding this ^^^, you're right, so we avoid to add "fsl,imx-osc", but at this point, does it make sense we create a patchset to remove it from the other .dts(i) files that use it? And same goes for "fsl,imx-ckil", "fsl,imx-ckih1", "fsl,imx-ckih2"?
I see that those try to repeat the name of the node itself so they are useless. If you say so I send a patchset for that.
Thank you Best regards -- Giulio Benetti Benetti Engineering sas
| |