lkml.org 
[lkml]   [2021]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[RFC PATCH 0/1] topdown with metrics
Date
Hi John,

> BTW, I was looking at adding perf tool --topdown support for arm64. This will require L1 metricgroup support per core - see what I did here for our hisilicon platform already:
>
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/metrics.json
>
> I would like to add support for more cores. Generally the arm common events match up to the definitions here:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/Documentation/perf-stat.txt#n400
>
> Apart from frontend_bound - would you have an equivalent metric expression for this for these Neoverse cores?
>
> [0] Note that I think that the divisor in the metric expressions is max uops that the core can deal with.

Thanks for this, we’ve been working on how to support perf --topdown.
We’re still considering the right events/calculations on our CPUs.

To introduce the calculations in metrics jsons we would like this patch
to alter the --topdown option on arm64.

How does this fit with your solution?

Andrew


Andrew Kilroy (1):
perf arm64: Implement --topdown with metrics

tools/perf/arch/arm64/util/Build | 1 +
tools/perf/arch/arm64/util/topdown.c | 8 ++++++++
tools/perf/builtin-stat.c | 13 +++++++++++++
tools/perf/util/metricgroup.c | 12 ++++++++++++
tools/perf/util/metricgroup.h | 7 +++++++
tools/perf/util/topdown.c | 6 ++++++
tools/perf/util/topdown.h | 1 +
7 files changed, 48 insertions(+)
create mode 100644 tools/perf/arch/arm64/util/topdown.c

--
2.17.1

\
 
 \ /
  Last update: 2021-12-14 19:43    [W:0.152 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site