lkml.org 
[lkml]   [2021]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/26] x86/tdx: Handle CPUID via #VE
    Date
    In TDX guests, most CPUID leaf/sub-leaf combinations are virtualized
    by the TDX module while some trigger #VE.

    Implement the #VE handling for EXIT_REASON_CPUID by handing it through
    the hypercall, which in turn lets the TDX module handle it by invoking
    the host VMM.

    More details on CPUID Virtualization can be found in the TDX module
    specification [1], the section titled "CPUID Virtualization".

    [1] - https://software.intel.com/content/dam/develop/external/us/en/documents/tdx-module-1.0-public-spec-v0.931.pdf

    Co-developed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
    Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
    Reviewed-by: Andi Kleen <ak@linux.intel.com>
    Reviewed-by: Tony Luck <tony.luck@intel.com>
    Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    ---
    arch/x86/kernel/tdx.c | 42 ++++++++++++++++++++++++++++++++++++++++--
    1 file changed, 40 insertions(+), 2 deletions(-)

    diff --git a/arch/x86/kernel/tdx.c b/arch/x86/kernel/tdx.c
    index 8be8090ca19f..e1c757d1720c 100644
    --- a/arch/x86/kernel/tdx.c
    +++ b/arch/x86/kernel/tdx.c
    @@ -130,6 +130,31 @@ static bool tdx_write_msr_safe(unsigned int msr, unsigned int low,
    return ret ? false : true;
    }

    +static bool tdx_handle_cpuid(struct pt_regs *regs)
    +{
    + struct tdx_hypercall_output out;
    +
    + /*
    + * Emulate the CPUID instruction via a hypercall. More info about
    + * ABI can be found in TDX Guest-Host-Communication Interface
    + * (GHCI), section titled "VP.VMCALL<Instruction.CPUID>".
    + */
    + if (_tdx_hypercall(EXIT_REASON_CPUID, regs->ax, regs->cx, 0, 0, &out))
    + return false;
    +
    + /*
    + * As per TDX GHCI CPUID ABI, r12-r15 registers contain contents of
    + * EAX, EBX, ECX, EDX registers after the CPUID instruction execution.
    + * So copy the register contents back to pt_regs.
    + */
    + regs->ax = out.r12;
    + regs->bx = out.r13;
    + regs->cx = out.r14;
    + regs->dx = out.r15;
    +
    + return true;
    +}
    +
    bool tdx_get_ve_info(struct ve_info *ve)
    {
    struct tdx_module_output out;
    @@ -166,8 +191,18 @@ bool tdx_get_ve_info(struct ve_info *ve)
    */
    static bool tdx_virt_exception_user(struct pt_regs *regs, struct ve_info *ve)
    {
    - pr_warn("Unexpected #VE: %lld\n", ve->exit_reason);
    - return false;
    + bool ret = false;
    +
    + switch (ve->exit_reason) {
    + case EXIT_REASON_CPUID:
    + ret = tdx_handle_cpuid(regs);
    + break;
    + default:
    + pr_warn("Unexpected #VE: %lld\n", ve->exit_reason);
    + break;
    + }
    +
    + return ret;
    }

    /* Handle the kernel #VE */
    @@ -190,6 +225,9 @@ static bool tdx_virt_exception_kernel(struct pt_regs *regs, struct ve_info *ve)
    case EXIT_REASON_MSR_WRITE:
    ret = tdx_write_msr_safe(regs->cx, regs->ax, regs->dx);
    break;
    + case EXIT_REASON_CPUID:
    + ret = tdx_handle_cpuid(regs);
    + break;
    default:
    pr_warn("Unexpected #VE: %lld\n", ve->exit_reason);
    break;
    --
    2.32.0
    \
     
     \ /
      Last update: 2021-12-14 16:05    [W:3.937 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site