Messages in this thread | | | Subject | Re: [RFC PATCH 2/2] Droid3: add initial DTS | From | Merlijn Wajer <> | Date | Tue, 14 Dec 2021 22:30:06 +0100 |
| |
Hi Tony,
On 13/12/2021 07:01, Tony Lindgren wrote: > * Merlijn Wajer <merlijn@wizzup.org> [211212 23:00]: >> @@ -35,7 +35,7 @@ reserved-memory { >> * first 512K of that and just overwrite the rest and configure >> * only 384K instead of 2M. >> */ >> - ramoops@a0080000 { >> + ramoops0: ramoops@a0080000 { >> compatible = "ramoops"; >> reg = <0xa0080000 0x60000>; >> record-size = <0x20000>; > > The stock kernel ramoops range might be different here because of less > memory. If the stock kernel has it, it should be in the platform data > somewhere in the stock kernel sources. Probably best to just leave it > out for now.
Understood -- I didn't see it in the stock kernel, so perhaps ramoops is not available on this device.
>> +// Do don't know if pstore is supported, but the current config causes panics, >> +// so delete the node for now >> +/delete-node/ &ramoops0; > > Just leave this out too, I don't think we have the ramoops configured in > the mainline kernel.
Oops, yeah.
> Otherwise looks good to me.
Thanks for review!
Regards, Merlijn
| |