lkml.org 
[lkml]   [2021]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH V5 3/6] drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver
    Hi Charles, Mwesigwa, Joel, Serge,

    On Fri, Dec 10, 2021 at 11:11 PM Charles Mirabile <cmirabil@redhat.com> wrote:
    >
    > Signed-off-by: Charles Mirabile <cmirabil@redhat.com>
    > Co-developed-by: Mwesigwa Guma <mguma@redhat.com>
    > Signed-off-by: Mwesigwa Guma <mguma@redhat.com>
    > Co-developed-by: Joel Savitz <jsavitz@redhat.com>
    > Signed-off-by: Joel Savitz <jsavitz@redhat.com>

    The "submitting author" should be the last one, i.e.:

    Co-developed-by: Mwesigwa Guma <mguma@redhat.com>
    Signed-off-by: Mwesigwa Guma <mguma@redhat.com>
    Co-developed-by: Joel Savitz <jsavitz@redhat.com>
    Signed-off-by: Joel Savitz <jsavitz@redhat.com>
    Signed-off-by: Charles Mirabile <cmirabil@redhat.com>

    > +config SENSEHAT_DISPLAY
    > + tristate "Raspberry pi Sense HAT display driver"

    pi -> Pi

    > +static int sensehat_update_display(struct sensehat *sensehat);

    Can the function be directly defined instead?

    > + if (*f_pos >= VMEM_SIZE)
    > + return 0;
    > + if (*f_pos + count > VMEM_SIZE)
    > + count = VMEM_SIZE - *f_pos;

    `min` / `min_t`?

    > + if (ret < 0)
    > + dev_err(sensehat->dev,
    > + "Update to 8x8 LED matrix display failed");

    Could this happen a lot of times? Is it expected to happen under some
    condition or should never happen?

    Cheers,
    Miguel

    \
     
     \ /
      Last update: 2021-12-11 19:39    [W:4.568 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site