lkml.org 
[lkml]   [2021]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] block: cancel all throttled bios in del_gendisk()
On Wed, Dec 01, 2021 at 05:40:14PM +0800, Yu Kuai wrote:
> + /*
> + * hold queue_lock to prevent concurrent with dispatching
> + * throttled bios by timer.
> + */
> + spin_lock_irq(&q->queue_lock);
> + rcu_read_lock();

Can you see whether it still needs rcu_read_lock() while holding queue_lock?
Now that all RCU flavors are merged, I think just holding the queue_lock
should be enough here.

Looks good otherwise.

Thanks.

--
tejun

\
 
 \ /
  Last update: 2021-12-01 18:02    [W:0.340 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site