lkml.org 
[lkml]   [2021]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net-next v3 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021.
Date
Hi Andrew,

Thank you very much for review.

I'll move properties nvmem-cells and nvmem-cell-names to ethernet ports
and change value of nvmem-cell-names to "mac-address" next patch.

I'll refer to "nvmem_get_mac_address()" when modifying code.


Best regards,
Wells


> > + nvmem-cells:
> > + items:
> > + - description: nvmem cell address of MAC address of 1st MAC
> > + - description: nvmem cell address of MAC address of 2nd MAC
> > +
> > + nvmem-cell-names:
> > + description: names corresponding to the nvmem cells of MAC address
> > + items:
> > + - const: mac_addr0
> > + - const: mac_addr1
>
> These are port properties, so put them in the port section.
>
> Also, the name you should use is well defined, "mac-address". See nvmem_get_mac_address().
> But you won't be able to use that helper because it take dev, not an of node.
>
> Andrew
\
 
 \ /
  Last update: 2021-12-01 08:03    [W:0.104 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site