lkml.org 
[lkml]   [2021]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v2] most: replace snprintf in show functions with sysfs_emit
    On Thu, Nov 04, 2021 at 11:45:40AM +0000, cgel.zte@gmail.com wrote:
    > From: Jing Yao <yao.jing2@zte.com.cn>
    >
    > coccicheck complains about the use of snprintf() in sysfs show
    > functions:
    > WARNING use scnprintf or sprintf
    >
    > Use sysfs_emit instead of scnprintf, snprintf or sprintf makes more
    > sense.
    >
    > Reported-by: Zeal Robot <zealci@zte.com.cn>
    > Signed-off-by: Jing Yao <yao.jing2@zte.com.cn>
    > ---
    >
    > Changes since v1:
    > - Actually, the robot which is composed of lots of tools includes
    > coccienlle.
    > - Change the ignored snprintf().
    > - Change the wrong Subject.

    Ok, this is much better, but note that there are a lot more instances
    like this in the "most" subsystem which this patch is not addressing so
    the patch prefix should really have been:

    "most: usb: ..."

    since you're only handling the most usb driver.

    > drivers/most/most_usb.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/most/most_usb.c b/drivers/most/most_usb.c
    > index acabb7715b42..73258b24fea7 100644
    > --- a/drivers/most/most_usb.c
    > +++ b/drivers/most/most_usb.c
    > @@ -831,7 +831,7 @@ static ssize_t value_show(struct device *dev, struct device_attribute *attr,
    > int err;
    >
    > if (sysfs_streq(name, "arb_address"))
    > - return snprintf(buf, PAGE_SIZE, "%04x\n", dci_obj->reg_addr);
    > + return sysfs_emit(buf, "%04x\n", dci_obj->reg_addr);
    >
    > if (sysfs_streq(name, "arb_value"))
    > reg_addr = dci_obj->reg_addr;
    > @@ -843,7 +843,7 @@ static ssize_t value_show(struct device *dev, struct device_attribute *attr,
    > if (err < 0)
    > return err;
    >
    > - return snprintf(buf, PAGE_SIZE, "%04x\n", val);
    > + return sysfs_emit(buf, "%04x\n", val);
    > }
    >
    > static ssize_t value_store(struct device *dev, struct device_attribute *attr,

    Other than that, looks good:

    Reviewed-by: Johan Hovold <johan@kernel.org>

    Johan

    \
     
     \ /
      Last update: 2021-11-08 10:50    [W:3.019 / U:0.292 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site