lkml.org 
[lkml]   [2021]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 0/4] HID: wiiu-drc: Add a driver for the Wii U gamepad
On Thu, Nov 04, 2021 at 12:21:37PM +0100, Emmanuel Gil Peyrot wrote:
> On Tue, Oct 19, 2021 at 11:30:06AM +0200, Jiri Kosina wrote:
> > On Tue, 19 Oct 2021, Emmanuel Gil Peyrot wrote:
> […]
> > > Another driver I’d like to submit eventually is the GameCube Controller
> > > Adapter for Wii U, which does exactly what its name says, but being an
> > > external USB adapter it also works on any USB computer; would it make
> > > sense to develop it alongside the current driver, just because it is
> > > sold by the same company?
> >
> > We generally group the support for HID devices in drivers based on the
> > producing company, with a few exceptions where it doesn't make sense.
>
> Speaking of which, would you want me to also merge hid-wiimote into
> hid-nintendo? Or is there a reason it is separate besides legacy?
>

Would naming the drivers with a "nintendo-" prefix while keeping them
separate be an acceptable solution? Since these drivers share no common
code, merging them will result in a big driver with different parts for
unrelated hardware (save for the maker company), which doesn't seem
right.

For the gamecube adapter driver, I'd prefer to keep it separate; but
I'll integrate it to hid-nintendo as Emmanuel did for the wii-u if
that's the preferred option.

\
 
 \ /
  Last update: 2021-11-05 18:28    [W:0.115 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site