Messages in this thread | | | Date | Thu, 4 Nov 2021 09:10:19 -0500 | From | Tyler Hicks <> | Subject | Re: [PATCH] mfd: simple-mfd-i2c: Fix linker error due to new mfd-core dependency |
| |
On 2021-11-04 15:00:40, Robert Marko wrote: > On Thu, Nov 4, 2021 at 2:53 PM Tyler Hicks <tyhicks@linux.microsoft.com> wrote: > > > > On 2021-11-04 08:24:28, Lee Jones wrote: > > > On Wed, 03 Nov 2021, Tyler Hicks wrote: > > > > > > > Select CONFIG_MFD_CORE from CONFIG_MFD_SIMPLE_MFD_I2C, now that > > > > simple-mfd-i2c.c calls devm_mfd_add_devices(), to fix the following > > > > linker error: > > > > > > > > ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe': > > > > simple-mfd-i2c.c:(.text+0x62): undefined reference to `devm_mfd_add_devices' > > > > make: *** [Makefile:1187: vmlinux] Error 1 > > > > > > > > Fixes: c753ea31781a ("mfd: simple-mfd-i2c: Add support for registering devices via MFD cells") > > > > Cc: stable@vger.kernel.org # 5.15.x > > > > Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com> > > > > --- > > > > drivers/mfd/Kconfig | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > Looks like the same change that has already been applied. > > > > > > Could you rebase on top of the MFD tree please? > > > > Ah, that commit wasn't in for-mfd-next when I wrote up this patch > > yesterday. > > > > I think that the Fixes line in that patch is wrong as I didn't see this > > issue in 5.10 and reverting c753ea31781a fixes the build failure. > > Hi Tyler, I would agree with you on the fixes tag. > I messed that one up, c753ea31781a is the correct one.
It is probably better to overshoot than undershoot with Fixes tags. :)
Lee, I don't know if you rebase that branch (I doubt it) but if you do to fix up the Fixes tag, please also add an explicit Cc: stable tag since this affects the new LTS release.
Tyler
> > Regards, > Robert > > > > Tyler > > > > > > > > -- > > > Lee Jones [李琼斯] > > > Senior Technical Lead - Developer Services > > > Linaro.org │ Open source software for Arm SoCs > > > Follow Linaro: Facebook | Twitter | Blog > > > > > > > -- > Robert Marko > Staff Embedded Linux Engineer > Sartura Ltd. > Lendavska ulica 16a > 10000 Zagreb, Croatia > Email: robert.marko@sartura.hr > Web: www.sartura.hr >
| |