lkml.org 
[lkml]   [2021]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.10 24/43] mmc: spi: Add device-tree SPI IDs
    Date
    From: Jon Hunter <jonathanh@nvidia.com>

    [ Upstream commit 5f719948b5d43eb39356e94e8d0b462568915381 ]

    Commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT
    compatible") added a test to check that every SPI driver has a
    spi_device_id for each DT compatiable string defined by the driver
    and warns if the spi_device_id is missing. The spi_device_id is
    missing for the MMC SPI driver and the following warning is now seen.

    WARNING KERN SPI driver mmc_spi has no spi_device_id for mmc-spi-slot

    Fix this by adding the necessary spi_device_id.

    Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
    Link: https://lore.kernel.org/r/20211115113813.238044-1-jonathanh@nvidia.com
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mmc/host/mmc_spi.c | 7 +++++++
    1 file changed, 7 insertions(+)

    diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
    index 02f4fd26e76a9..17aad7ef0c7b5 100644
    --- a/drivers/mmc/host/mmc_spi.c
    +++ b/drivers/mmc/host/mmc_spi.c
    @@ -1523,6 +1523,12 @@ static int mmc_spi_remove(struct spi_device *spi)
    return 0;
    }

    +static const struct spi_device_id mmc_spi_dev_ids[] = {
    + { "mmc-spi-slot"},
    + { },
    +};
    +MODULE_DEVICE_TABLE(spi, mmc_spi_dev_ids);
    +
    static const struct of_device_id mmc_spi_of_match_table[] = {
    { .compatible = "mmc-spi-slot", },
    {},
    @@ -1534,6 +1540,7 @@ static struct spi_driver mmc_spi_driver = {
    .name = "mmc_spi",
    .of_match_table = mmc_spi_of_match_table,
    },
    + .id_table = mmc_spi_dev_ids,
    .probe = mmc_spi_probe,
    .remove = mmc_spi_remove,
    };
    --
    2.33.0
    \
     
     \ /
      Last update: 2021-11-30 15:54    [W:3.865 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site