lkml.org 
[lkml]   [2021]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net v2] selftests/fib_tests: ping from dummy0 in fib_rp_filter_test()
Hi David,

On Mon, Nov 29, 2021 at 06:16:48PM -0700, David Ahern wrote:
> On 11/29/21 5:49 PM, Peilin Ye wrote:
> > - run_cmd "ip netns exec ns1 ping -I dummy1 -w1 -c1 198.51.100.1"
> > + run_cmd "ip netns exec ns1 ping -I dummy0 -w1 -c1 198.51.100.1"
> > log_test $? 0 "rp_filter passes local packets"
>
> confused by the point of this test if you are going to change dummy1 to
> dummy0. dummy0 has 198.51.100.1 assigned to it, so the ping should
> always work.

Ah... Thanks for pointing this out, I'll try to figure out a different
way to test it in v3.

Thanks,
Peilin Ye

\
 
 \ /
  Last update: 2021-11-30 06:14    [W:0.083 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site