lkml.org 
[lkml]   [2021]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 00/15] x86: Support Key Locker
Date
On Nov 29, 2021, at 19:27, Eric Biggers <ebiggers@kernel.org> wrote:
> On Wed, Nov 24, 2021 at 12:06:45PM -0800, Chang S. Bae wrote:
>>
>> == Non Use Cases ==
>>
>> Bare metal disk encryption is the only use case intended by these patches.
>
> If that's the case, why are so many encryption modes being added (ECB, CTR, CBC,
> and XTS)? Wouldn't just XTS be sufficient?

Right, it would reduce the crypt library changes significantly. But it is
clueless whether XTS is sufficient to support DM-crypt, because a user may
select the kernel’s crypto API via ‘capi:', [1].

>> * PATCH10-15: For the x86 crypto library, it first prepares the AES-NI code
>> to accommodate the new AES implementation. Then incrementally add base
>> functions and various modes support -- ECB, CBC, CTR, and XTS. The code
>> was found to pass the crypto test.
>
> Did you test with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y?

Yes.

Thanks,
Chang

[1] https://gitlab.com/cryptsetup/cryptsetup/-/wikis/DMCrypt
\
 
 \ /
  Last update: 2021-11-30 07:37    [W:0.145 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site