Messages in this thread | | | Date | Wed, 1 Dec 2021 12:02:56 +0800 | From | kernel test robot <> | Subject | Re: [PATCH v3 03/13] perf/x86/amd: add AMD Fam19h Branch Sampling support |
| |
Hi Stephane,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/perf/core] [also build test WARNING on tip/x86/core rafael-pm/linux-next v5.16-rc3 next-20211130] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Stephane-Eranian/perf-x86-amd-Add-AMD-Fam19h-Branch-Sampling-support/20211201-090506 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git a9f4a6e92b3b319296fb078da2615f618f6cd80c config: i386-tinyconfig (https://download.01.org/0day-ci/archive/20211201/202112011125.Yf5fkhH3-lkp@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/c6b0817d81501a8bc31ddd7067697dba4408d75f git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Stephane-Eranian/perf-x86-amd-Add-AMD-Fam19h-Branch-Sampling-support/20211201-090506 git checkout c6b0817d81501a8bc31ddd7067697dba4408d75f # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/events/amd/
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
arch/x86/events/amd/core.c: In function 'amd_pmu_enable_all': >> arch/x86/events/amd/core.c:676:24: warning: variable 'hwc' set but not used [-Wunused-but-set-variable] 676 | struct hw_perf_event *hwc; | ^~~
vim +/hwc +676 arch/x86/events/amd/core.c
672 673 static void amd_pmu_enable_all(int added) 674 { 675 struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events); > 676 struct hw_perf_event *hwc; 677 int idx; 678 679 amd_brs_enable_all(); 680 681 for (idx = 0; idx < x86_pmu.num_counters; idx++) { 682 hwc = &cpuc->events[idx]->hw; 683 684 /* only activate events which are marked as active */ 685 if (!test_bit(idx, cpuc->active_mask)) 686 continue; 687 688 amd_pmu_enable_event(cpuc->events[idx]); 689 } 690 } 691
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
| |