lkml.org 
[lkml]   [2021]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] fs: remove duplicate permission checks in do_sendfile()
Date
The permission check for out.file is mainly performed in the function
rw_verify_area(), and this check is called twice in the function
do_splice_direct() and before calling do_splice_direct(). This is a
redundant check and it is necessary to remove.

Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
---
fs/read_write.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/fs/read_write.c b/fs/read_write.c
index 0074afa7ecb3..bc7c3fcc3400 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -1238,9 +1238,6 @@ static ssize_t do_sendfile(int out_fd, int in_fd, loff_t *ppos,
#endif
opipe = get_pipe_info(out.file, true);
if (!opipe) {
- retval = rw_verify_area(WRITE, out.file, &out_pos, count);
- if (retval < 0)
- goto fput_out;
file_start_write(out.file);
retval = do_splice_direct(in.file, &pos, out.file, &out_pos,
count, fl);
--
2.32.0
\
 
 \ /
  Last update: 2021-11-30 09:03    [W:0.048 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site