lkml.org 
[lkml]   [2021]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 51/64] cachefiles: Implement the I/O routines
    Date
    Nathan Chancellor <nathan@kernel.org> wrote:

    > This patch as commit 0443b01eccbb ("cachefiles: Implement the I/O
    > routines") in -next causes the following clang warning/error:
    >
    > fs/cachefiles/io.c:489:6: error: variable 'ret' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
    > if (pos == 0)
    > ^~~~~~~~
    > fs/cachefiles/io.c:492:6: note: uninitialized use occurs here
    > if (ret < 0) {
    > ^~~
    > fs/cachefiles/io.c:489:2: note: remove the 'if' if its condition is always true
    > if (pos == 0)
    > ^~~~~~~~~~~~~
    > fs/cachefiles/io.c:440:9: note: initialize the variable 'ret' to silence this warning
    > int ret;
    > ^
    > = 0
    > 1 error generated.

    pos = cachefiles_inject_remove_error();
    if (pos == 0)
    ret = vfs_fallocate(file, FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE,

    That should be:

    ret = cachefiles_inject_remove_error();
    if (ret == 0)
    ret = vfs_fallocate(file, FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE,

    David

    \
     
     \ /
      Last update: 2021-11-30 22:07    [W:2.316 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site