lkml.org 
[lkml]   [2021]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 7/7] tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LEN
    On Mon, 29 Nov 2021 23:33:33 +0800
    Yafang Shao <laoar.shao@gmail.com> wrote:

    > > TBH, i would vote for reverting the change. defining an array size as
    > > enum feels really odd.
    > >
    >
    > We changed it to enum because the BTF can't parse macro while it can
    > parse the enum type.

    I wonder if BTF could take advantage of the tracing:

    TRACE_DEFINE_ENUM() macros?

    This is how they are converted for user space tooling.

    Anyway, I'd have to go and look at why that trigger test failed. I don't
    see how the size of the array caused it to change the signage of value.

    -- Steve


    > Anyway I don't insist on keeping this change if you think reverting it
    > is better.

    \
     
     \ /
      Last update: 2021-11-29 17:11    [W:3.257 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site