Messages in this thread | | | Subject | Re: [PATCH] libertas: Use struct_group() for memcpy() region | From | Kalle Valo <> | Date | Mon, 29 Nov 2021 10:44:41 +0000 (UTC) |
| |
Kees Cook <keescook@chromium.org> wrote:
> In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memcpy(), memmove(), and memset(), avoid > intentionally writing across neighboring fields. > > Use struct_group() in struct txpd around members tx_dest_addr_high > and tx_dest_addr_low so they can be referenced together. This will > allow memcpy() and sizeof() to more easily reason about sizes, improve > readability, and avoid future warnings about writing beyond the end > of queue_id. > > "pahole" shows no size nor member offset changes to struct txpd. > "objdump -d" shows no object code changes. > > Signed-off-by: Kees Cook <keescook@chromium.org>
Patch applied to wireless-drivers-next.git, thanks.
5fd32ae0433a libertas: Use struct_group() for memcpy() region
-- https://patchwork.kernel.org/project/linux-wireless/patch/20211118184104.1283637-1-keescook@chromium.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |