lkml.org 
[lkml]   [2021]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 001/179] scsi: sd: Fix sd_do_mode_sense() buffer length handling
    Date
    From: Damien Le Moal <damien.lemoal@wdc.com>

    commit c749301ebee82eb5e97dec14b6ab31a4aabe37a6 upstream.

    For devices that explicitly asked for MODE SENSE(10) use, make sure that
    scsi_mode_sense() is called with a buffer of at least 8 bytes so that the
    sense header fits.

    Link: https://lore.kernel.org/r/20210820070255.682775-4-damien.lemoal@wdc.com
    Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/scsi/sd.c | 7 +++++++
    1 file changed, 7 insertions(+)

    --- a/drivers/scsi/sd.c
    +++ b/drivers/scsi/sd.c
    @@ -2607,6 +2607,13 @@ sd_do_mode_sense(struct scsi_disk *sdkp,
    unsigned char *buffer, int len, struct scsi_mode_data *data,
    struct scsi_sense_hdr *sshdr)
    {
    + /*
    + * If we must use MODE SENSE(10), make sure that the buffer length
    + * is at least 8 bytes so that the mode sense header fits.
    + */
    + if (sdkp->device->use_10_for_ms && len < 8)
    + len = 8;
    +
    return scsi_mode_sense(sdkp->device, dbd, modepage, buffer, len,
    SD_TIMEOUT, sdkp->max_retries, data,
    sshdr);

    \
     
     \ /
      Last update: 2022-09-17 16:12    [W:2.476 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site