Messages in this thread | | | Subject | Re: [PATCH v2 2/2] scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT formatting | From | "Martin K. Petersen" <> | Date | Mon, 29 Nov 2021 22:59:58 -0500 |
| |
Florian,
> The format used for formatting SYSFS_FLAG_FW_SEL_BOOT creates the > following warning: > > drivers/scsi/qedi/qedi_main.c:2259:35: warning: format specifies type > 'char' but the argument has type 'int' [-Wformat] > rc = snprintf(buf, 3, "%hhd\n", > SYSFS_FLAG_FW_SEL_BOOT); > > Fix this to cast the constant as an u8 since the intention is to print > it via sysfs as a byte.
The other occurrences of SYSFS_FLAG_FW_SEL_BOOT use "%d". Since %hh is deprecated I suggest you just fix the snprintf().
-- Martin K. Petersen Oracle Linux Engineering
| |