lkml.org 
[lkml]   [2021]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] usb: aspeed-vhub: add qualifier descriptor
From
Date
On Fri, 2021-11-26 at 19:09 +0800, Neal Liu wrote:
>
> @@ -417,10 +435,9 @@ enum std_req_rc ast_vhub_std_hub_request(struct ast_vhub_ep *ep,
>
> /* GET/SET_CONFIGURATION */
> case DeviceRequest | USB_REQ_GET_CONFIGURATION:
> - return ast_vhub_simple_reply(ep, 1);
> + return ast_vhub_simple_reply(ep, vhub->current_config);
> case DeviceOutRequest | USB_REQ_SET_CONFIGURATION:
> - if (wValue != 1)
> - return std_req_stall;
> + vhub->current_config = wValue;
> return std_req_complete;

This is odd.. why should we support arbitrary SET_CONFIGURATION for
configs we don't support ?

Otherwise looks good.

Cheers,
Ben.


\
 
 \ /
  Last update: 2021-11-30 00:48    [W:0.074 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site