lkml.org 
[lkml]   [2021]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 051/121] ASoC: codecs: wcd934x: return error code correctly from hw_params
    Date
    From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

    [ Upstream commit 006ea27c4e7037369085755c7b5389effa508c04 ]

    Error returned from wcd934x_slim_set_hw_params() are not passed to upper layer,
    this could be misleading to the user which can start sending stream leading
    to unnecessary errors.

    Fix this by properly returning the errors.

    Fixes: a61f3b4f476e ("ASoC: wcd934x: add support to wcd9340/wcd9341 codec")
    Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
    Link: https://lore.kernel.org/r/20211116114623.11891-3-srinivas.kandagatla@linaro.org
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/wcd934x.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c
    index d18ae5e3ee809..699b59cd389c0 100644
    --- a/sound/soc/codecs/wcd934x.c
    +++ b/sound/soc/codecs/wcd934x.c
    @@ -1812,9 +1812,8 @@ static int wcd934x_hw_params(struct snd_pcm_substream *substream,
    }

    wcd->dai[dai->id].sconfig.rate = params_rate(params);
    - wcd934x_slim_set_hw_params(wcd, &wcd->dai[dai->id], substream->stream);

    - return 0;
    + return wcd934x_slim_set_hw_params(wcd, &wcd->dai[dai->id], substream->stream);
    }

    static int wcd934x_hw_free(struct snd_pcm_substream *substream,
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-29 23:49    [W:2.436 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site