lkml.org 
[lkml]   [2021]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 44/69] NFSv42: Dont fail clone() unless the OP_CLONE operation failed
    Date
    From: Trond Myklebust <trond.myklebust@hammerspace.com>

    [ Upstream commit d3c45824ad65aebf765fcf51366d317a29538820 ]

    The failure to retrieve post-op attributes has no bearing on whether or
    not the clone operation itself was successful. We must therefore ignore
    the return value of decode_getfattr() when looking at the success or
    failure of nfs4_xdr_dec_clone().

    Fixes: 36022770de6c ("nfs42: add CLONE xdr functions")
    Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/nfs/nfs42xdr.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/fs/nfs/nfs42xdr.c b/fs/nfs/nfs42xdr.c
    index ec9803088f6b8..eee011de3f58b 100644
    --- a/fs/nfs/nfs42xdr.c
    +++ b/fs/nfs/nfs42xdr.c
    @@ -707,8 +707,7 @@ static int nfs4_xdr_dec_clone(struct rpc_rqst *rqstp,
    status = decode_clone(xdr);
    if (status)
    goto out;
    - status = decode_getfattr(xdr, res->dst_fattr, res->server);
    -
    + decode_getfattr(xdr, res->dst_fattr, res->server);
    out:
    res->rpc_status = status;
    return status;
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-29 23:15    [W:2.548 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site