Messages in this thread | | | Subject | Re: [PATCH v6 1/3] dt-bindings: mediatek: add adsp-mbox document | From | AngeloGioacchino Del Regno <> | Date | Fri, 26 Nov 2021 12:36:02 +0100 |
| |
Il 26/11/21 10:30, allen-kh.cheng ha scritto: > From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> > > This patch adds document for mediatek adsp mbox > > Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> > --- > .../bindings/mailbox/mtk,adsp-mbox.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml > > diff --git a/Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml b/Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml > new file mode 100644 > index 000000000000..a0149566ae56 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mailbox/mtk,adsp-mbox.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek ADSP mailbox > + > +maintainers: > + - Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> > + > +description: | > + The MTK ADSP mailbox Inter-Processor Communication (IPC) enables the SoC > + to ommunicate with ADSP by passing messages through two mailbox channels. > + The MTK ADSP mailbox IPC also provides the ability for one processor to > + signal the other processor using interrupts. > + > +properties: > + compatible: > + items: > + - const: mediatek,mt8195-adsp-mbox > + > + "#mbox-cells": > + const: 0 > + > + reg: > + description: > + Physical address base for dsp mbox base registers. > + > + interrupts: > + description: > + adsp mbox interrupt > + > +required: > + - compatible > + - "#mbox-cells" > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + adsp_mailbox0:adsp_mailbox0@10816000 {
This should be:
adsp_mailbox0: mailbox@10816000 {
> + compatible = "mediatek,mt8195-adsp-mbox"; > + #mbox-cells = <0>; > + reg = <0x10816000 0x1000>; > + interrupts = <GIC_SPI 702 IRQ_TYPE_LEVEL_HIGH 0>; > + }; >
Regards, - Angelo
| |